Just in case you wondered how many photos you really can have in your Apple Photos library, I can report that I have so far added 1 000 264 Photos and 10 242 Videos without any issues.
I’m fairly impressed and happy about it since all I could find was that it should support up to 100.000 photos, with a few reasoning about the limit being increased to 300.000 on modern hardware.
I’m running this on my MacBook Pro M2 Max with 64 GB ram.
Most formats gets converted to HEIC and HEVC on import, which are staggeringly effective compared to their original formats. The whole library file still only takes up 1.7TB, which is much less than expected. The original source on my NAS is around 5.6 TB.
Edit: Maybe I should add that I do not recommend this, and view it as an experiment for now. I’m still importing data. If it’s still stable and performant after a year and some OS updates then I can start recommending it.
Have you noticed any discrepancies between what’s on you drive and what’s in iCloud? I’ve had clients with much smaller libraries that would have say 50,000 on iCloud but 50,100 on their Mac. How do you figure out what’s missing? AFAIK there’s no way to tell Photos to resync with iCloud.